Refactor sel vector interface #3177
Merged
+98
−92
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR ends up being a pure renaming PR.
We rename
resetSelectorToUnselected
tosetToUnfiltered
to be consistent withisUnfiltered
. AndresetSelectorToValuePosBuffer
tosetToMutable
. The reasons are as followreset
has a very specific meaning of setting to initial state. Out interface inSelVector
clearly not qualify this notion.resetSelectorToValuePosBuffer
is quite confusing because developer do not know whatValuePosBuffer
is suppose to be. We should avoid name an interface by naively describing a code block (e.g.resetSelectorToValuePosBuffer
is just describingselectedPositions = selectedPositionsBuffer.get();
). Instead, call itsetToMutable
makes more sense because by defaultselectedPositions
points to a static array that is immutable.I also take the chance to examine if we were using
SelVector
wrongly. I spot a few pieces where @ray6080 should comment as it is storage code.